generated from crossplane/provider-template
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for DefaultPrivileges in postgres #199
Open
xocasdashdash
wants to merge
17
commits into
crossplane-contrib:master
Choose a base branch
from
xocasdashdash:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xocasdashdash
force-pushed
the
master
branch
2 times, most recently
from
October 27, 2024 08:52
271b438
to
de33b05
Compare
Well i manage to get this deployed to kind but it involves
and then it "just works" |
Signed-off-by: Joaquín Fernández Campo <[email protected]>
Signed-off-by: Joaquín Fernández Campo <[email protected]>
…oller Signed-off-by: Joaquín Fernández Campo <[email protected]>
Signed-off-by: Joaquín Fernández Campo <[email protected]>
Signed-off-by: Joaquín Fernández Campo <[email protected]>
Signed-off-by: Joaquín Fernández Campo <[email protected]>
Signed-off-by: Joaquín Fernández Campo <[email protected]>
Signed-off-by: Joaquín Fernández Campo <[email protected]>
Signed-off-by: Joaquín Fernández Campo <[email protected]>
…ources we can add default privileges Signed-off-by: Joaquín Fernández Campo <[email protected]>
Signed-off-by: Joaquín Fernández Campo <[email protected]>
Signed-off-by: Joaquín Fernández Campo <[email protected]>
Signed-off-by: Joaquín Fernández Campo <[email protected]>
Signed-off-by: Joaquín Fernández Campo <[email protected]>
Signed-off-by: Joaquín Fernández Campo <[email protected]>
Signed-off-by: Joaquín Fernández Campo <[email protected]>
Signed-off-by: Joaquín Fernández Campo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds support to DefaultPrivileges for postgres.
Fixes #117
I have:
make reviewable
to ensure this PR is ready for review.How has this code been tested
I've been trying to test this locally but i'm really struggling to deploy the provider to a local kind cluster.
It's following the same pattern as the grants, we only care about the creation of the default privileges as the grant/revoke runs in a single transaction.